Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Black #1718

Merged
merged 9 commits into from
May 28, 2020
Merged

Fix Black #1718

merged 9 commits into from
May 28, 2020

Conversation

ehennenfent
Copy link
Contributor

@ehennenfent ehennenfent commented May 28, 2020

The checkout V2 action only pulls a single commit by default. In order to diff against the base commit, we need to fetch that as well.

Eric Hennenfent added 8 commits May 28, 2020 11:13
Github Actions doesn't update the head variable despite the checkout action merging the active branch into `master`, so the commit range specified was invalid
@ehennenfent ehennenfent marked this pull request as ready for review May 28, 2020 19:13
The modified files got missed due to black not properly running on our CI
Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ehennenfent ehennenfent merged commit 6747143 into master May 28, 2020
@ehennenfent ehennenfent deleted the dev-fix-black branch May 28, 2020 19:54
ekilmer added a commit that referenced this pull request Jun 15, 2020
* master:
  Symbolic model for strcpy (#1681)
  Rollback to support yices again (#1714)
  Fix default output space when workspace is in mem: (#1724)
  VMTests tests for istanbul (#1676)
  Snapshots & is_main (#1710)
  Fix Black (#1718)
  Use CoverageRC, Make CodeCov Less Aggressive (#1705)
  Fix plugin enable/disable magic (#1708)
  Add a warning when selected no methods for inclusion (#1707)
  Remove duplicated entries (#1709)
  Blacken (#1711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants