Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental coverage changes #1705

Merged
merged 7 commits into from
May 19, 2020
Merged

Experimental coverage changes #1705

merged 7 commits into from
May 19, 2020

Conversation

ehennenfent
Copy link
Contributor

@ehennenfent ehennenfent commented May 12, 2020

Tells coverage.py to respect the top-level coveragerc file, and makes CodeCov tolerate a small drop in overall coverage percentage to account for nondeterministic gas tests.

Eric Hennenfent added 7 commits May 12, 2020 14:07
Tells coverage.py to record coverage for individual test cases, and makes CodeCov tolerate a small drop in overall coverage percentage to account for nondeterministic gas tests.
Appears to break use of subprocess in integration tests
@ehennenfent ehennenfent marked this pull request as ready for review May 15, 2020 23:21
@ehennenfent ehennenfent requested a review from bradlarsen May 18, 2020 18:15
Copy link
Contributor

@bradlarsen bradlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the COVERAGE_RCFILE variable isn't actually needed, let's get rid of that. (If it is needed, that's fine.)

LGTM! Thanks!

.github/workflows/ci.yml Show resolved Hide resolved
@ehennenfent ehennenfent merged commit 2c90ee0 into master May 19, 2020
@ehennenfent ehennenfent deleted the exp-coverage branch May 19, 2020 21:58
ekilmer added a commit that referenced this pull request Jun 15, 2020
* master:
  Symbolic model for strcpy (#1681)
  Rollback to support yices again (#1714)
  Fix default output space when workspace is in mem: (#1724)
  VMTests tests for istanbul (#1676)
  Snapshots & is_main (#1710)
  Fix Black (#1718)
  Use CoverageRC, Make CodeCov Less Aggressive (#1705)
  Fix plugin enable/disable magic (#1708)
  Add a warning when selected no methods for inclusion (#1707)
  Remove duplicated entries (#1709)
  Blacken (#1711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants