-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docusaurus website #875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timocov
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, is it possible to generate favicon from svg on the fly?
timocov
reviewed
Nov 8, 2021
I'm sure it's possible. We would have to write something custom. Do you think it's something we should do? |
timocov
reviewed
Nov 11, 2021
timocov
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR: enhancement
PR checklist:
Overview of change:
This PR adds a documentation website built with Docusaurus.
See https://edew.github.io/lightweight-charts/ for a demo.
There's a lot that we can improve. Interactive examples, more tutorials, etc. but this is a good start.
Is there anything you'd like reviewers to focus on?
Once we are happy with this and it is merged the
noIndex
option can be disabled - I have left it on for now so (hopefully) the version of the site hosted on my personal GitHub Pages branch isn't indexed.