-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs website and improve the docs #411
Comments
Some time ago I also looked at some "static site generators" to get site with the docs, but afaik there was some issues. I think we need to solve (at least) the following questions:
I might miss something, so please let me know what do you think :) |
I don't know if Tradingview wants to maintain full control but I'll answer how I do it for my website.
I use Netlify, it is especially good for statics sites. It has a CI/CD with (auto)deployment configs, that can be configured per branch. I can have the site on my account (it's free) unless you want to retain full control.
It seems to be supported out of the box if needed but I haven't tried it. Docusaurus versioning
Is supported this way: https://docusaurus.io/docs/en/search#__docusaurus.
This is independent of Docusaurus. Maybe there are some modules out there that can generate api pages to markdown, then Docusaurus will pick them up. I personally don't use typescript much but I do use jsdocs a lot. A quick search on npm lead to modules like these: jsdoc-to-markdown so we could probably do something about it. |
I think it'd be better, so we can control full workflow and make changes if we need some, independently of someone outside (don't get me wrong please). I meant that, for example, if you'll on vacation and we need to make some changes, we'll unable to do so and will wait you some time. I just think that it'd better to have full control of the whole pipeline/state in one place.
I've heard about that but never use it yet 👍. It's kind of now.sh and so on, right?
Yeah, agree. Am I correct that the whole Docusaurus' config, settings files, some headers/footers should be placed in the repo, right? |
@timocov This library / project is mine bard-router and the docs are made with Docusaurus, if you want a better idea of how it looks like. Same setup, Netlify + Docusaurus. The docs (docusaurus) are in documentation folder. I just have a simple command in Netlify CI. Regarding your comment about the updates to the docs, it would not be a problem if I were not available because the deploy process is entirely through Git, you don't need to do anything with Netlify once configured. (That doesn't remove the fact that it's better if you have full control, just saying you wouldn't be blocked for docs updates) If you want, I can build a prototype as it would be faster at the beginning, then I'll transfer everything to you. (I'd do this in my free time, so it's a best effort approach ;)) |
Hey @AoDev, sorry for really late reply.
Yeah, let's do it 💪 |
Cool, I'll start : ) |
@timocov I've deployed a quick draft, so you can say if we go forward with this solution. Things to take into account right now:
To me it looks much easier to find information already. |
Search has been added. |
@AoDev Looks good! 👍 I guess we need to adopt our docs a bit to make "readable" and "searchable", but anyway it's other question though. |
@timocov Yep, I'll do the setup then you will be able to configure everything however you want. How should we continue? I fix the images and make a PR with a bit of documentation about how it works? |
Yeah, looks good for me 👍.
We didn't decide anything about that, so I think we can start from Netlify. I guess it shouldn't be hard to move to any other platform in the future, let's don't waste time on it now. |
I believe this should be fixed in #875 |
Is your feature request related to a problem? Please describe.
Sometimes it's hard for me to find the documentation for something in particular, although the information is there.
Describe the solution you'd like
I'd like to create better docs for the lightweight-charts.
My plan is to use Docusaurus to build the docs. I already use it for another project so it should be relatively easy to setup docs for this library. Markdown can be used, so we can just copy paste current docs as a first step.
Before I begin I thought it would be better to share this idea with you, to know whether you want to do this together or not, have some thoughts or constraints.
On my side, I can do it alone and completely standalone, but docs could be in this repo too. Let me know. : )
The text was updated successfully, but these errors were encountered: