Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated scales design #607

Merged
merged 41 commits into from
Jun 20, 2022
Merged

Updated scales design #607

merged 41 commits into from
Jun 20, 2022

Conversation

eugene-korobko
Copy link
Contributor

Type of PR: enhancement

PR checklist:

Overview of change:
Changed scales look & feel according to the new design

@timocov timocov changed the title 606: Update scales design Updated scales design Nov 6, 2020
@timocov timocov self-requested a review November 12, 2020 09:57
@timocov timocov added this to the 4.0 milestone Jul 20, 2021
@timocov timocov added the breaking change Changes the API in a non backwards compatible way. label Jul 20, 2021
@timocov timocov mentioned this pull request Mar 7, 2022
Closed
kirchet
kirchet requested changes May 20, 2022
View reviewed changes
src/helpers/make-font.ts Outdated Show resolved Hide resolved
src/renderers/time-axis-view-renderer.ts Outdated Show resolved Hide resolved
src/views/price-axis/price-axis-view.ts Outdated Show resolved Hide resolved
@kirchet
Copy link
Contributor

kirchet commented May 24, 2022

  • Also we need to change the default value to false here. No breaking change notes required because it's a new option
  • Size limit tests failed
  • The test cases do-not-draw-price-ticks.js, do-not-draw-time-ticks.js, apply-do-not-draw-price-ticks.js should be inverted

kirchet
kirchet reviewed May 27, 2022
View reviewed changes
.size-limit.js Outdated Show resolved Hide resolved
@eugene-korobko eugene-korobko force-pushed the 606-update-scales-design branch from db3a188 to f639d70 Compare May 31, 2022 12:18
kirchet
kirchet previously approved these changes Jun 2, 2022
View reviewed changes
kirchet
kirchet previously approved these changes Jun 15, 2022
View reviewed changes
kirchet
kirchet previously approved these changes Jun 15, 2022
View reviewed changes
@edew edew merged commit f28f811 into master Jun 20, 2022
@edew edew deleted the 606-update-scales-design branch June 20, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirchet kirchet kirchet approved these changes

@timocov timocov Awaiting requested review from timocov

Assignees

@eugene-korobko eugene-korobko

Labels
breaking change Changes the API in a non backwards compatible way.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Update scales design
4 participants
@eugene-korobko @kirchet @timocov @edew