Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scales design #606

Closed
eugene-korobko opened this issue Oct 29, 2020 · 7 comments · Fixed by #607
Closed

Update scales design #606

eugene-korobko opened this issue Oct 29, 2020 · 7 comments · Fixed by #607
Assignees
@eugene-korobko
Labels
breaking change Changes the API in a non backwards compatible way. enhancement Feature requests, and general improvements.
Milestone
4.0

Comments

@eugene-korobko
Copy link
Contributor

Updates scales and its labels according to the attached design images
@eugene-korobko
Copy link
Contributor Author

cross-hair-label

@eugene-korobko
Copy link
Contributor Author

series-labels

@eugene-korobko
Copy link
Contributor Author

time-scale

@eugene-korobko eugene-korobko self-assigned this Oct 29, 2020
@eugene-korobko eugene-korobko mentioned this issue Oct 29, 2020
Merged
3 tasks
@timocov timocov added the enhancement Feature requests, and general improvements. label Nov 6, 2020
@timocov timocov modified the milestones: 3.2, Future, 4.0 Nov 6, 2020
@timocov timocov added the breaking change Changes the API in a non backwards compatible way. label Nov 13, 2020
@DTupalov
Copy link

DTupalov commented May 5, 2021

@timocov @eugene-korobko, this issue only update actual price scale design or you give api to set custom design for labels?

Would I be able to make such design after closing this issue?
image

@timocov
Copy link
Contributor

timocov commented May 5, 2021

@DTupalov it's about updating the default design for price labels.

@thanhlmm
Copy link

Will it have radius settings @timocov ?

@timocov
Copy link
Contributor

timocov commented Jul 29, 2021

Will it have radius settings @timocov ?

@thanhlmm Not in this change. Can you please create another issue for that so after this issue will be closed we can start to work on adding the new features/overrides.

@edew edew closed this as completed in #607 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugene-korobko eugene-korobko

Labels
breaking change Changes the API in a non backwards compatible way. enhancement Feature requests, and general improvements.
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Updated scales design tradingview/lightweight-charts
4 participants
@DTupalov @timocov @eugene-korobko @thanhlmm