-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for excellon drill files w/ leading/trailing set in M71/M72 line #96
Added support for excellon drill files w/ leading/trailing set in M71/M72 line #96
Conversation
Thanks @davidworkman9, this looks like a good change. M71 and M72 are listed as valid inch and metric commands in this archived version of the Excellon "spec". As for tests, it looks like a sub-dependency was unpublished from npm for some reason, so CI is broken because that version doesn't exist in the lockfile. I'll need to fix that up, and I'll ping you here once it's done so you can rebase. Sorry for the inconvenience. Once that's fixed, make sure you're in the repository root and do: npm install
npm test (Same instructions as in the "contributing" section of the readme) |
CI job was fixed with #97. I'd recommend rebasing your branch and giving tests another shot! |
@davidworkman9 were you able to make any progress on rebasing? |
a159747
to
41d3e69
Compare
Codecov Report
@@ Coverage Diff @@
## next #96 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 49 49
Lines 2058 2058
=======================================
Hits 1940 1940
Misses 118 118
Continue to review full report at Codecov.
|
Thanks @mcous I was able to get a test environment running after rebasing. |
…g from M71/M72 measuring comman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This looks great
Released as:
|
Thanks @mcous ! |
Ran into a drill file recently that started off like this:
I don't know that this is official syntax, but this adds support for files like it.
Note this is completely untested. I started writing tests, but couldn't figure out how to get them to run. It appears there's a bunch of unmarked dependencies required to get a test environment working.