-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.1.2 backwards compatibility, and unpublished version. #112
Comments
interesting, I'm going to dig into this today, and see what can be done. |
I have unpublished |
@patsjo can you please provide me with some reproducible steps? |
Hi, this error is breaking one of our builds. It just started happening within the last 24 hours. I can reproduce just by doing [edit] sorry... it only works when i'm in the specific project. trying to figure out what version of ajv we're using, because it's not a direct dependency |
OK, I figured it out on our end. It just so happened that we needed to bump a dependency and update our package-lock.json at the moment that 5.1.2 was available. I fixed the issue for us by just deleting package-lock.json and re-creating with |
Need to let you know the impact of unpublishing on dependent libs. It's failing a yarn install.
Our dependencies are: => Found "strong-remoting#[email protected]" As a strategy, I'd perhaps suggest you either bump to a 5.1.3 that reverts the bad behavior or to republish 5.1.1 and 5.1.2 as copies of 5.1.0 so we don't get a 404 error on yarn/npm install, because of fixed dependencies in *.lock files |
Publishing a rolled back v5.1.3 would have been preferred to unpublishing 5.1.2. This is causing major headaches from nexus and artifactory users. |
unpublishing 5.1.2 has caused an outage on our circle-ci tests, please, release a 5.1.3 version before the whole universe goes mad about you! :) |
Also seeing 404 errors during installs; Ideally we should be releasing a |
@ahmadnassri Can you give folks an update as to your plan/timing to resolve this issue? |
Here is what is blocking our builds: $ npm list har-validator |
I'm investigating the issue, so far nobody has provided me with any reproducible steps.
there was never any broken code pushed or changes made, other than bumping |
for folks with cached a @patsjo what version of node are you on? |
AJV’s readme is wrong. It only supports Node.js 6 #109 (comment) As for har-validator itself, the CircleCI config should be amended to cover all supported versions so something like this doesn’t happen. Best thing right now would probably be to rerelease 5.1.0 as 5.1.3 and 5.1.2 as 6.0. |
The version 5.1.2 of har-validator was unpublished on npm. See ahmadnassri/node-har-validator#112
The version 5.1.2 of har-validator was unpublished on npm. See ahmadnassri/node-har-validator#112
Yes
Seems that the unpublishing has left yarn registry dirty. |
I don't / can't support
They also don't have any method of interacting with their registry to do things like unpublish: yarnpkg/yarn#4746 unpublishing packages is part of the expected behavior of a registry, and of dependency management. a registry or registry client does not take care of managing your dependencies for you, you still have to do your part in managing your dependencies in your apps. @seprich also see these issues with Yarn that are going on unresolved: yarnpkg/yarn#5212 I'm sorry, but |
also, see conversation thread here: https://twitter.com/AhmadNassri/status/1062733707579219968 it might just be that your lock files need to be updated @seprich |
> npm ERR! 404 Not Found: [email protected] Related to ahmadnassri/node-har-validator#112
Hi @ahmadnassri, I encounter this bug today, reproduction steps: In a Mac, using yarn, tried to install Hope it helps! I'll try to spare some time to give a hand if I can. |
hey @amypellegrini the issue is in your lock file, likely needs a refresh, installation works fine without a lock file, so there must be a conflict in there. |
@ahmadnassri It sound strange it is related only to package-lock, I went all the way down to delete the entire node installation and it was still happening. Only when I manually npm installed har-validator 5.1.3 as a direct dependency I was able to solve the issue. |
It seems .1 and .2 were removed which breaks setups. Was there a good reason to unpublish / remove them? |
yarnpkg is just a proxy for npmjs so this is not true. Yarn always uses the lockfile, |
@pgonzal yarn and npm create tags when you use the |
@Glathrop no, a simple proxy, they both use Cloudflare and yarnpkg.com points to npmjs.com ;-) A mirror would be a copy on Yarn's side. (like a RAID mirror mode). |
I removed package-lock.json, execute "npm i". Then cleared cache on heroku https://coderwall.com/p/jjcpra/clean-heroku-npm-cache |
ahmadnassri/node-har-validator#112 (comment) The version present in lockfile is unplublished. Updated it to now resolved with latest published version Signed-off-by: Vivek Vaibhaw Dwivedi <[email protected]>
…er unpublish Needed to work around ahmadnassri/node-har-validator#112
…er unpublish (#97) Needed to work around ahmadnassri/node-har-validator#112
For yarn users: If you have a yarn.lock file referencing the since-unpublished version of har-validator, then removing your yarn.lock file and re-running |
I'm facing this weird issue on my machine with Windows 10 x64. I tried several time to rebuild the lockfile but for some unknown reasons, the Everyone can try this little finding of mine to see if it works for you. |
Because the author unpublished 5.1.2 (ill-advisedly). For background, see ahmadnassri/node-har-validator#112
Yarn has a global lockfile. If this issue is preventing you from using |
har-validator v5.1.2 was removed from npmjs [1], so it can’t be installed anymore. Use v5.1.3 instead. [1]: ahmadnassri/node-har-validator#112 Change-Id: I17a836d7a17443a42891bcb24073ebfbfe1ea383
Deleting the global lockfile as @jamesgecko suggested worked for me, but the file was located at |
this library has not been maintained, nor has any further planned maintenance. I made a dependency update release today and this will be the last one. this repo will be archived. |
ahmadnassri/node-har-validator#112 (comment) The version present in lockfile is unplublished. Updated it to now resolved with latest published version Signed-off-by: Vivek Vaibhaw Dwivedi <[email protected]>
So this resolved my issue. I first ran |
ahmadnassri/node-har-validator#112 (comment) The version present in lockfile is unplublished. Updated it to now resolved with latest published version Signed-off-by: Vivek Vaibhaw Dwivedi <[email protected]>
Between 5.1.1 and 5.1.2 the package.json changed version of ajv from ^5.3.0 to ^6.5.5.
When some other package (like request 2.88.0) has a dependency of har-validator ~5.1.0, it can cause other things to break if you allow a major dependency change, without changing you own major version.
In my case, I cant build any more. I got the error:
ERROR in bundle-a54549f6346a118c4764.js from UglifyJs
SyntaxError: Unexpected token: name (length) [./~/punycode/punycode.js:55,0]
This error is because ajv from version 5.x.x to 6.x.x. forced punycode to change major version aswell. (nothing wrong with that)
The text was updated successfully, but these errors were encountered: