Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust naming and comments #214

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Adjust naming and comments #214

merged 1 commit into from
Oct 30, 2024

Conversation

AsherJingkongChen
Copy link
Contributor

@AsherJingkongChen AsherJingkongChen commented Oct 29, 2024 •
edited
Loading

There were three init_device* previously.

I found that it could be easier to identify, so I made this change.

Previous Current
init_device_on_setup init_device
init_device_async init_setup
init_device init_setup_async

@AsherJingkongChen AsherJingkongChen mentioned this pull request Oct 29, 2024
Merged
@nathanielsimard
Copy link
Member

I think the names are better, what do you think @ArthurBrussee?

@ArthurBrussee
Copy link
Contributor

ArthurBrussee commented Oct 30, 2024 •
edited
Loading

Clearly previous names were confusing so all for it! Thanks for fixing them

Edit: Ah also only just noticed I flipped async / sync, woops!

@nathanielsimard nathanielsimard merged commit c86a83a into tracel-ai:main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsherJingkongChen @nathanielsimard @ArthurBrussee