Allow for overriding device, return device setup #210
Conversation
crates/cubecl-wgpu/src/runtime.rs
Outdated
| pub async fn create_wgpu_setup<G: GraphicsApi, C: WgpuCompiler>(device: &WgpuDevice) -> WgpuSetup { | ||
| let (instance, adapter) = select_adapter::<G>(device).await; |
There was a problem hiding this comment.
Hmm yeah it's confusing with the functions init_async and init_sync. Maybe instead of init we could have register_setup_sync and register_setup_async. Also we could remove wgpu from the function name here, since it's in the wgpu project: create_setup is probably sufficient.
There was a problem hiding this comment.
Yeah this could do with better naming. Register didn't feel right. This function does create new things, not just sign them up somewhere. Initialization is better imo (or maybe create). I went for this in the end:
- init_sync -> init_device_sync.
- init -> init_device
- init_existing_device -> init_device_on_setup
- create_client -> create_client_on_setup, and is now private, doesn't need to be public
- create_wgpu_setup -> create_setup_for_device, and is now private, doesn't need to be public
Lmk how that looks.
|
|
||
| /// Create a `WgpuDevice` on an existing `WgpuSetup`. Useful when you want to share | ||
| /// a device between CubeCL and other wgpu libraries. | ||
| pub fn init_device_on_setup(setup: WgpuSetup, options: RuntimeOptions) -> WgpuDevice { |
There was a problem hiding this comment.
I am confused, are they all creating and registering devices?
fn init_device_on_setup(WgpuSetup) -> WgpuDeviceasync fn init_device(WgpuDevice) -> WgpuSetupfn init_device_async(WgpuDevice) -> WgpuSetupasync fn create_setup_for_device(WgpuDevice) -> WgpuSetup
There was a problem hiding this comment.
Init_device and init_device_async are for initializing a cube WgpuDevice, and create all the wgpu resources.
init_device_on_setup initializes a cube WgpuDevice given existing wgpu resources.
Sorry if they are a bit confusing, maybe other names could be better!
There was a problem hiding this comment.
I have figured out their usage. However, I revised function names based on suggestions from nathanielsimard in #214.
It'd be nice to allow for automatically overriding the wgpu device cube uses when using WgpuDevice::BestAvailable.
This PR adds a CUBECL_WGPU_DEVICE env var that be overriden. The names are the same as the enum - just implemented manually for now, I don't think it's worth pulling in more complex enum parsing machinery.
Additionally, this PR: