Fix warnings when loading net/protocol #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
commented
Mar 19, 2021
As described in https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/, Ruby 3.0.0 promoted net-http and net-imap from stdlib. Adding net-http as a dependency avoids "already initialized constant errors" if net-imap and faraday are used. See ruby/net-imap#16 (comment) for more details.
stanhu
force-pushed
the
sh-fix-net-protocol-warnings
branch
from
0c79dce to
15d4588
Compare
net-http needs Ruby 2.6, so we'll have to drop this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/, Ruby 3.0.0 promoted net-http and net-imap from stdlib. Adding net-http as a dependency avoids "already initialized constant errors" if net-imap and faraday are used. See ruby/net-imap#16 (comment) for
more details.