Skip to content

Commit

Permalink
Fix warnings when loading net/protocol
Browse files Browse the repository at this point in the history
As described in https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/, Ruby
3.0.0 promoted net-http and net-imap from stdlib. Adding net-http as a
dependency avoids "already initialized constant errors" if net-imap and
faraday are used.  See
ruby/net-imap#16 (comment) for
more details.
  • Loading branch information
stanhu committed Mar 21, 2021
1 parent 24ba25b commit 15d4588
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions mail_room.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ Gem::Specification.new do |gem|

# for testing delivery methods
gem.add_development_dependency "faraday"
# Ruby v3.0.0 made net-http a default gem. This dependency is needed to eliminate
# warnings when faraday is used. See https://github.com/lostisland/faraday-net_http/pull/5.
gem.add_development_dependency "net-http", "~> 0.1"
gem.add_development_dependency "mail"
gem.add_development_dependency "letter_opener"
gem.add_development_dependency "redis", "~> 3.3.1"
Expand Down

0 comments on commit 15d4588

Please sign in to comment.