-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-379: Change clear-cache to clear-temp #382
Conversation
Converted to draft quickly as the documentation also has to be updated |
Personally I'd prefer to keep the class name matching what the actual command name is despite users never seeing it. I'd prefer this because it can help with understanding the codebase, especially for someone who is looking to contribute. |
Apart from the 1 remark it looks to me (without compiling atm as I don't have the time, will tomorrow) as if all previous mentions to cached files are changed now, new sentences look understandable aswell! |
I think I'm overall happy with where we landed on this. Going to merge this in. Thanks for the help! |
Small change but decided I would get it done