viewmodel expect/actual #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2022
|
You should update https://github.com/touchlab/KaMPKit/blob/main/docs/GENERAL_ARCHITECTURE.md with the new structure. Explaining the different layers of viewmodel on native side would be helpful |
samhill303
reviewed
Mar 21, 2022
shared/src/iosMain/kotlin/co/touchlab/kampkit/BreedCallbackViewModel.kt
Outdated
Show resolved
Hide resolved
|
re readme updates, I think that'll come as part of the separate docs update pass we've been talking about |
samhill303
approved these changes
Mar 24, 2022
kpgalligan
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate take on #231 that uses an expect/actual base class in order to avoid one layer of wrapper class on the Android side. This feels nicer in a greenfield context, but has less flexibility to deal with certain scenarios that can come up when migrating a pre-existing app to KMP, such as differences in what functionality is supported per platform, and usage of Android-specific APIs like LiveData.