View Model Refactor Concept - Shared Interface #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Summary]
There is another way to handle state than the previous 2 ways, and I
wanted the best aspects of both of them:
- mutually exclusive states
- No nullability
- Easy reasoning at the View level
[Fix]
Make DataState a sealed class, but give each a loading Boolean
[Testing]
- `./gradlew :app:build`
- `./gradlew :shared:build`
- `xcodebuild -workspace ios/KaMPKitiOS.xcworkspace -scheme KaMPKitiOS
-sdk iphoneos -configuration Debug build -destination name="iPhone 8"`
- manual testing
[Summary]
The code in NativeViewModel and MainViewModel (Android) is nearly
identical.
[Fix]
We can make them both implement an interface with mostlydefault
functions, and keep platform-specific code minimal.
[Testing]
- `./gradlew :app:build`
- `./gradlew :shared:build`
- `xcodebuild -workspace ios/KaMPKitiOS.xcworkspace -scheme KaMPKitiOS
-sdk iphoneos -configuration Debug build -destination name="iPhone 8"`
- manual testing
KevinSchildhorn
changed the title
Merged
|
PR #238 is a merge of the view model concept PRs. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code in NativeViewModel and MainViewModel (Android) is nearly identical.
Fix
We can make them both implement an interface with mostly default functions, and keep platform-specific code minimal. Platform-specific stuff:
CoroutineScopefor eachFlows through callbacks for iOSTesting
./gradlew :app:build./gradlew :shared:buildxcodebuild -workspace ios/KaMPKitiOS.xcworkspace -scheme KaMPKitiOS -sdk iphoneos -configuration Debug build -destination name="iPhone 8"