-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pp rework #202
Merged
Merged
feat: pp rework #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotRikD
commented
Oct 10, 2024
packages/tosu/package.json
Outdated
@@ -24,7 +24,7 @@ | |||
"osu-standard-stable": "^5.0.0", | |||
"osu-taiko-stable": "^5.0.0", | |||
"resedit": "^2.0.0", | |||
"rosu-pp-js": "^1.0.2", | |||
"@kotrikd/rosu-pp": "1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for release, its just a temp update for testing new pp
KotRikD
force-pushed
the
feat/pp_rework
branch
from
October 10, 2024 21:05
75ba399
to
665544c
Compare
If somebody wanna play with it - https://github.com/tosuapp/tosu/actions/runs/11281986247 |
cyperdark
force-pushed
the
feat/pp_rework
branch
from
October 19, 2024 11:43
2057abd
to
8c90b9e
Compare
the current implementation should be the working one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on MaxOhn/rosu-pp#43 for latest pp rework (I believe?)