Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pp rework #202

Merged
merged 8 commits into from
Oct 30, 2024
Merged

feat: pp rework #202

merged 8 commits into from
Oct 30, 2024

Conversation

KotRikD
Copy link
Member

@KotRikD KotRikD commented Oct 10, 2024

Based on MaxOhn/rosu-pp#43 for latest pp rework (I believe?)

@@ -24,7 +24,7 @@
"osu-standard-stable": "^5.0.0",
"osu-taiko-stable": "^5.0.0",
"resedit": "^2.0.0",
"rosu-pp-js": "^1.0.2",
"@kotrikd/rosu-pp": "1.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for release, its just a temp update for testing new pp

@KotRikD KotRikD marked this pull request as draft October 10, 2024 21:00
@KotRikD
Copy link
Member Author

KotRikD commented Oct 10, 2024

If somebody wanna play with it - https://github.com/tosuapp/tosu/actions/runs/11281986247

@cyperdark
Copy link
Collaborator

image

@cyperdark
Copy link
Collaborator

the current implementation should be the working one

@KotRikD KotRikD closed this Oct 23, 2024
@KotRikD KotRikD deleted the feat/pp_rework branch October 23, 2024 12:25
@cyperdark cyperdark restored the feat/pp_rework branch October 30, 2024 22:16
@cyperdark cyperdark reopened this Oct 30, 2024
@cyperdark cyperdark marked this pull request as ready for review October 30, 2024 22:17
@KotRikD KotRikD merged commit 2d5ac58 into master Oct 30, 2024
3 checks passed
@KotRikD KotRikD deleted the feat/pp_rework branch October 31, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants