Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port pp update #43

Merged
merged 48 commits into from
Nov 18, 2024
Merged

feat: port pp update #43

merged 48 commits into from
Nov 18, 2024

Conversation

MaxOhn
Copy link
Owner

@MaxOhn MaxOhn commented Sep 27, 2024

Checklist

@MaxOhn MaxOhn marked this pull request as ready for review October 30, 2024 10:20
@natsukagami
Copy link

effective_miss_count =
full_combo_threshold / total_imperfect_hits(&state).max(1.0);

Should this be something like full_combo_threshold / (state.max_combo as f64).max(1.0) instead? Looking at osu's code it does this

https://github.com/ppy/osu/blob/0811de728e4205a45e485d53ccdaf19a937c6033/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs#L71-L72

@MaxOhn
Copy link
Owner Author

MaxOhn commented Nov 3, 2024

That's true, good catch 😄

Testing will be very light for this update, at least for the time being. osu-tools has some issues preventing me from using it this time and it's way too slow anyway so I'll be waiting for the next score data dump and test against that but it'll likely be a month or two until that's available.

Actually, the data dump already includes scores with data post-update so I wrote a test suite which already caught a bunch of bugs and should give a lot more confidence in my implementation.

@MaxOhn MaxOhn merged commit 9f45d95 into main Nov 18, 2024
5 checks passed
@MaxOhn MaxOhn deleted the pp-update branch November 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants