Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example task extraction #127
Example task extraction #127
Changes from 5 commits
64f54a3
82ac9fc
1087a7e
c4c5bf9
a782286
557014e
2e36719
85160da
156c7be
1c9bbd7
4675a8f
64bec1f
00cd503
d5024cb
3d1afe7
c76652a
7f9a103
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But remove the unused variable
trans
.The changes improve the accuracy and reliability of the database deletion process. However, the variable
trans
is assigned but never used.Committable suggestion
Tools
Ruff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling for empty data chunks.
Consider logging a warning or raising an exception if
data_chunks
is empty to ensure proper handling.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper error handling for external calls.
The function makes several asynchronous calls. It's important to handle potential errors that might arise from these calls.
Add similar error handling for other asynchronous calls within the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper error handling for data point creation.
The function makes several asynchronous calls to create data points. It's important to handle potential errors that might arise from these calls.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider breaking down nested loops for readability.
Nested loops can be hard to read and maintain. Consider breaking them down into smaller functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize the deletion of disconnected nodes.
The deletion of disconnected nodes can be optimized by combining the checks and deletions.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper error handling for external calls.
The function makes several asynchronous calls to
graph_engine
. It's important to handle potential errors that might arise from these calls.Add similar error handling for other asynchronous calls within the function.