feat: Extract dependencies #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaskasprzyk
requested review from
tomekdz,
wzieba,
milkagaca and
tomaszczart
lucaskasprzyk
force-pushed
the
feature/extract_dependencies
branch
from
11fe39f to
336daa8
Compare
tomaszczart
approved these changes
Nov 6, 2020
|
I'm not sure if it's direction we want to follow. Here are my arguments
It's a lot of work. I believe having only dependencies and its versions defined in separate Gradle script plugin. What are your thoughts? |
lucaskasprzyk
force-pushed
the
feature/extract_dependencies
branch
from
234c190 to
c271008
Compare
…ract_dependencies # Conflicts: # androidApp/build.gradle.kts # build.gradle.kts # domain/build.gradle.kts
|
Sorry, once again: why don't we use groovy file (which is supported by Dependabot) for declaring dependencies? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13
This PR introduce dependencies extraction, so we could maintain those in future development in easy way.
We have separate file
dependencies.gradle.ktswhere all dependencies and versions are stored.Also we use
extra propertiesso in future when it's available we could usedependabot