Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftLint #22

Closed
wants to merge 4 commits into from
Closed

Add SwiftLint #22

wants to merge 4 commits into from

Conversation

tomekdz
Copy link

@tomekdz tomekdz commented Oct 16, 2020

Closes #2

Adds SwiftLint configuration and a batch of trivial fixes indicated by it

@wzieba
Copy link
Contributor

wzieba commented Oct 16, 2020

@tomekdz can we please run lint in iOS CI workflow? Also I'd love someone from @tooploox/ios team to review this PR as well, that'd be great.

Base automatically changed from master to main January 17, 2021 13:27
@wzieba wzieba requested a review from patrykserek as a code owner January 17, 2021 13:27
@wzieba
Copy link
Contributor

wzieba commented Nov 16, 2022

hi @tomekdz 👋 could you please remove me from reviewers of this and:

PRs? I can't do that myself. Thanks!

Copy link

@skarol skarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to use fastlane for other things later on? Adding pods, gems & fastlane just to run swiftlint looks like too much. You could install it by homebrew and use it directly as a command line tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lint tools to swift code
5 participants