Support jruby #54
Support jruby #54
Conversation
.travis.yml
Outdated
| @@ -2,17 +2,14 @@ language: ruby | |||
| cache: bundler | |||
| sudo: false | |||
| rvm: | |||
| - 2.2 | |||
| - 2.3 | |||
| - 2.4 | |||
There was a problem hiding this comment.
[SHOULD] Ruby 2.4 is maintained yet.
EOL is 2020-03-31
https://www.ruby-lang.org/en/downloads/branches/
So I think this shouldn't be erased
There was a problem hiding this comment.
I see.
OK, I will revert removing old ruby CI.
.travis.yml
Outdated
| @@ -2,17 +2,14 @@ language: ruby | |||
| cache: bundler | |||
| sudo: false | |||
| rvm: | |||
| - 2.2 | |||
There was a problem hiding this comment.
[IMO] 2.2 and 2.3 are removed from build matrix.
This is soft deprecate? (build matrix is dropped, but users are allowed to install rspec-parameterized in ruby 2.2 and 2.3 )
or this is hard deprecate ? (we stop support in ruby 2.2 and 2.3)
In any case, I think that it is better to create another PR because it is different from the subject of PR (jruby support)
There was a problem hiding this comment.
I mean soft deprecation. Too many test cases waste travis's resources.
joker1007
force-pushed
the
support-jruby
branch
from
636f6c1 to
ab55669
Compare
|
:goodpoem: |
ref. #49, #50