Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding_ninja isn't JRuby compatible #49

Closed
malcolm-pro opened this issue Dec 6, 2018 · 2 comments
Closed

binding_ninja isn't JRuby compatible #49

malcolm-pro opened this issue Dec 6, 2018 · 2 comments

Comments

@malcolm-pro
Copy link

Hey y'all,

The new dependency on binding_ninja makes this library fail when compiling under JRuby. Here's the output:

current directory: /home/.rvm/gems/jruby-9.1.16.0/gems/binding_ninja-0.2.2/ext/binding_ninja
/home/.rvm/rubies/jruby-9.1.16.0/bin/jruby -r ./siteconf20181205-19971-1od2pas.rb extconf.rb
creating Makefile

current directory: /home/.rvm/gems/jruby-9.1.16.0/gems/binding_ninja-0.2.2/ext/binding_ninja
make "DESTDIR=" clean

current directory: /home/.rvm/gems/jruby-9.1.16.0/gems/binding_ninja-0.2.2/ext/binding_ninja
make "DESTDIR="
make: *** No rule to make target `/home/.rvm/rubies/jruby-9.1.16.0/lib/ruby/include/ruby/ruby.h', needed by `binding_ninja.o'.  Stop.

make failed, exit code 2

Looks like this library makes MRI-specific native extensions and can't be used under JRuby.

@malcolm-pro
Copy link
Author

(repeating this comment form the PR)

There is some code that explicitly references the BindingNinja constant. I wonder if it would be worth refactoring that library to give it API-parity with binding_of_caller.

In the meantime, we've been using v0.4.0, and it's been working great.

@joker1007 joker1007 mentioned this issue Apr 25, 2019
@joker1007
Copy link
Collaborator

I have already released v0.4.2 that is supported JRuby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants