Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post title block selectors in the editor #255

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

tomusborne
Copy link
Owner

@tomusborne tomusborne commented Sep 5, 2021

WordPress is planning on removing the wrapper element around the post title input in the editor: WordPress/gutenberg#34489 (comment)

This PR adjusts the selector we're using when targeting the input so we'll be ready for this change.

It's worth noting that our disable elements icon for the post title will also stop working when WP implements this change. We'll want to look at replacing it with a better solution before then.

@tomusborne tomusborne added bug Bugs, unexpected and weird behaviors priority: medium labels Sep 5, 2021
@tomusborne tomusborne added this to the 3.1.0 milestone Sep 5, 2021
@tomusborne tomusborne requested a review from JeanPaiva September 5, 2021 03:28
Copy link
Contributor

@JeanPaiva JeanPaiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@tomusborne tomusborne merged commit bb6758f into release/3.1.0 Sep 6, 2021
@tomusborne tomusborne deleted the update-post-title-block-selectors branch September 6, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs, unexpected and weird behaviors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants