Post title: remove class from old div to fix alignment #34489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Regression
|
Size Change: +627 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
This helps, thanks @ellatrix! It does look like some of the styles (specifically in Twenty Twenty, I haven't tested other themes yet) are still missing their targets. In the case of Twenty Twenty this impacts the size of the title and the alignment. While this PR currently centers the title element in the editor, the text within the element is still left aligned. Three screenshots for comparison: 11.3.0 (the goal) 11.4.0 (unpatched) This PR When comparing the first and last screenshots, it looks like the text is still smaller and not centered as it was pre-11.4 |
|
That's because the theme styling is no longer applying. What you see is the same as a h1 element. If you insert a post title block, you'll see that the styling is the same for that block. Eventually the post title will be replaced with a post title block. I think the small change in style is fine. There's no breakage and themes can adjust the selectors if they wish. |
@ellatrix Am I correct assuming those are then expected style changes in v11.4+ and that theme developers should be already aware of them and will fix them soon? |
|
There's also this z-index (?) glitch that @talldan reported: #34479 (comment), though it appears to be an older bug. |
fullofcaffeine
approved these changes
Sep 2, 2021
They are not aware, so maybe we should do a dev note when the WP release comes. To me it's no big deal since the title is still styled as heading level 1, and themes can choose to modify the styling if they wish. |
ellatrix
added
the
Needs Dev Note
|
Added the dev note label. Dev not should be something like: A div wrapper element around the post title in the post editor has been removed to align it better with the post title block. Some theme styles targeting the post title (that include the removed div's class name) may no longer apply. Please use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34479.
A div was removed in #34167. Instead of moving the class name to another div, we should just remove it as well. Also adds
block-editor-block-list__blockso some theme styles apply properly.Note that the post title refactors prepare it for switching over to the post title block eventually.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).