Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numed workers, logging exceptions fix #204

Merged
merged 2 commits into from
May 29, 2017

Conversation

xbeastx
Copy link
Contributor

@xbeastx xbeastx commented Dec 27, 2016

small fix

@coldfix
Copy link
Contributor

coldfix commented May 29, 2017

@xbeastx This seems mostly fine. One question: why are you removing the exception text from the warning (last chunk in the diff)

@xbeastx
Copy link
Contributor Author

xbeastx commented May 29, 2017

@coldfix logger.exception do all work inside.
https://docs.python.org/2/library/logging.html#logging.Logger.exception
Exception info is always added to the logging message. This method should only be called from an exception handler.

@coldfix
Copy link
Contributor

coldfix commented May 29, 2017

Oh thanks. I missed you changed to logging.exception.

Can you rebase against current master and resolve conflicts?

Many thanks, Thomas

@xbeastx
Copy link
Contributor Author

xbeastx commented May 29, 2017

@coldfix Done. Is it you @tomerfiliba ?

@tomerfiliba
Copy link
Collaborator

@xbeastx - coldfix is a maintainer now

@coldfix
Copy link
Contributor

coldfix commented May 29, 2017

No, I stepped in as maintainer until tomerfiliba has more time and wants to take back control.

@coldfix coldfix merged commit 4ef652e into tomerfiliba-org:master May 29, 2017
coldfix added a commit that referenced this pull request Jun 9, 2017
* Fix issue high-cpu polling (#191,#218)
* Fix filename argument in logging (#197)
* Improved log messages (#191,#204)
* Drop support for python 3.2 and py 2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants