Further fixes unveiled after fix for bug #182 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug in compat.py was unveiled after fixing bug tomerfiliba-org#182 and observing spinning processes. After that, the poll() call in server.py became too slow (1s instead of 1ms), leading to timeouts. The new value allows for not spinning too fast yet reacting quickly to new incoming connections.
glpatcern
force-pushed
the
master
branch
3 times, most recently
from
98cd813 to
12544f4
Compare
glpatcern
changed the title
coldfix
added a commit
that referenced
this pull request
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tomer,
I have found a couple of bugs unveiled after my fix for calling poll() from lib/compat instead of select(). The change in compat.py is self-explanatory.
At the same time, we have been chasing socket leaks in the
ThreadedPoolServerclass and you may want to include that patch as well.Cheers,
Giuseppe