test Spawn cargo add #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates crate dependencies to latest. It also fixes test failures introduced by the latest Rust toolchain. Tests are now put in a temporary directory instead of under `target`, which helps isolate the tests from one another.
…liance#205) Add `--workspace` and `--all-targets` switches to both vscode and emacs configs, that are generated in `cargo component new`. This is in line with what rust-analyzer uses when `rust-analyzer.check.overrideCommand` is empty.
…dealliance#206) * Try to use current package in the `add` command Add test `two_projects_in_one_workspace_validate_add_from_path` which cretes two projects in the same workspace. Run `cargo workspace add` in each of those projects without `--package` switch to check we are modifying the correct project/package. * Use `find_current_package_spec` in `publish` command
tomasol
force-pushed
the
spawn-cargo-add
branch
from
8982093 to
2f1bc48
Compare
…#211) This commit renames the `--reactor` option for the `new` subcommand to `--lib`. It maintains an alias of `--reactor` for backwards compatibility. Updated the tests to use `--lib` and added a test to ensure `--reactor` is still respected. Closes bytecodealliance#198.
This commit is a breaking change to `cargo-component` with the intention of improving component build time (now down to two transitive crate dependencies) and get `rust-analyzer` fully working with bindings. It removes the `cargo_component_bindings` and `cargo_component_macro` crates. Instead of using a macro for including the generated bindings, `cargo-component` now directly writes to a `src/bindings.rs` file which is included as a submodule in `main.rs` or `lib.rs`. Additionally, the `update` subcommand was removed as it is no longer necessary since there is no `cargo_component_bindings` crate referenced in `Cargo.toml`; the functionality to update `cargo-component` itself can simply be replaced with a `cargo install` or `cargo binstall`. Closes bytecodealliance#210.
peterhuene
force-pushed
the
spawn-cargo-add
branch
2 times, most recently
from
07ed8c9 to
1064284
Compare
peterhuene
force-pushed
the
spawn-cargo-add
branch
from
1064284 to
babf949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.