Check workspace with all targets in vscode, emacs configs #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like main is broken. I'm attempting to fix it in #206 |
peterhuene
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Looks good, thanks for the fix!
When #208 merges, we can rebase this PR on it and get it merged.
Add `--workspace` and `--all-targets` switches to both vscode and emacs configs, that are generated in `cargo component new`. This is in line with what rust-analyzer uses when `rust-analyzer.check.overrideCommand` is empty.
peterhuene
force-pushed
the
203-fix-vscode-config
branch
from
58a41f9 to
423a5f7
Compare
|
@tomasol thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--workspaceand--all-targetsswitches to both vscode and emacs configs, that are generated incargo component new. This is in line with what rust-analyzer uses whenrust-analyzer.check.overrideCommandis empty.Fixes #203 .