fix zombie variables #3137
fix zombie variables #3137
Conversation
🦋 Changeset detectedLatest commit: c0b1c1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
six7
force-pushed
the
fix/zombie-variables
branch
from
8b8d709
to
81bf10b
Compare
|
Commit SHA:0e8184ede0ae7f7d0776a5e7c73c3cf0e83e820c Test coverage results 🧪
|
There was a problem hiding this comment.
LGTM.
Does any usage of figma.variables.getLocalVariables() need to be replaced with (await getVariablesWithoutZombies()) going forward? Maybe a custom ESLint rule or something could be useful for this to prevent the bug from being reintroduced in the future.
Yes! There's a eslint rule by figma provided here: https://www.figma.com/plugin-docs/migrating-to-dynamic-loading/ we should add that |
Why does this PR exist?
Closes #3140
What does this pull request do?
This adds a check before we gather variables to use for references or for application, to see if the variable collection of those variables still exists.
Testing this change
Open a file affected by this bug (hard to replicate). File in DM with
@rboskerhas this: https://hyma-team.slack.com/archives/D03HL8WE738/p1726231101338089 - https://www.figma.com/design/foDPZl0c28gzctr6ztvNfy/Components-Roberto-(Copy)?t=I2ASNxMojuiwTyTv-0Before
After