Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new linting rules for Figma's new dynamic page loading #3142

Open
six7 opened this issue Sep 18, 2024 · 2 comments
Open

Introduce new linting rules for Figma's new dynamic page loading #3142

six7 opened this issue Sep 18, 2024 · 2 comments

Comments

@six7
Copy link
Collaborator

six7 commented Sep 18, 2024

Does any usage of figma.variables.getLocalVariables() need to be replaced going forward? Maybe a custom ESLint rule or something could be useful for this to prevent the bug from being reintroduced in the future.

Yes! There's a eslint rule by figma provided here: https://www.figma.com/plugin-docs/migrating-to-dynamic-loading/

we should add that

Originally posted by @six7 in #3137 (comment)

@six7
Copy link
Collaborator Author

six7 commented Oct 24, 2024

@macintoshhelper are you still working on this? Fine if not, please unassign then

@macintoshhelper macintoshhelper removed their assignment Oct 24, 2024
@macintoshhelper
Copy link
Contributor

I've unassigned myself for now. I was having issues with my local ESLint setup in VSCode which were blocking this. My ESLint setup appears to be fixed with this:

.vscode/settings.json

{
// ...
"eslint.workingDirectories": [
      {
          "mode": "location"
      }
  ],
// ...
}

And adding this to .eslintrc.js:

{
// ...
  parser: '@typescript-eslint/parser',
// ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📥 Triage
Development

No branches or pull requests

3 participants