This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
[LibOverhaul 04] Initialize all class members #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBriza
changed the title
MartinBriza
force-pushed
the
fix/library-overhaul/rebased/04-prefix-increment-operator
branch
from
275cd36 to
fdd0b63
Compare
NghiaTranUIT
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Since this PR branches off from https://github.com/toggl/toggldesktop/pull/3338 and contains 1 new commit toggl@fdd0b63, it's good to go.
However, I don't merge it until we address this problem https://github.com/toggl/toggldesktop/pull/3338#issuecomment-535377952
MartinBriza
force-pushed
the
fix/library-overhaul/rebased/04-prefix-increment-operator
branch
from
fdd0b63 to
420df8b
Compare
|
I have just rebased this PR against master and omitted the dependency on #3338. If the build passes, I'll merge it as per Nghia's review. There's also virtually no chance this would break anything. |
MartinBriza
deleted the
fix/library-overhaul/rebased/04-prefix-increment-operator
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Not explicitely initializing class member variables can lead to undefined behavior. Therefore I added explicit initialization to
nullptrto the ones that were not initialized.🕶️ Types of changes
🔎 Review hints