This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
[Do Not Merge][LibOverhaul 03] Update JsonCpp #3338
Open
MartinBriza
wants to merge
7
commits into
master
Choose a base branch
from
fix/library-overhaul/rebased/03-jsoncpp-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Do Not Merge][LibOverhaul 03] Update JsonCpp #3338
MartinBriza
wants to merge
7
commits into
master
from
fix/library-overhaul/rebased/03-jsoncpp-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest release doesn't amalgamate right
Basically, this PR works well on all platforms. I double-checked all primary features and it's as we expected. However, I encountered the crash when trying logging out. The log is pointing to JSON Parser. Therefore, I suppose we should take a look at it. How to reproduce
Screenshots |
NghiaTranUIT
suggested changes
Sep 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please investigate ☝️ issues
This was referenced Oct 2, 2019
I spent a good while testing this today and it crashes on random locations. I'm starting to suspect I discovered another race condition in the library.... |
MartinBriza
changed the title
[LibOverhaul 03] Update JsonCpp
[Do Not Merge][LibOverhaul 03] Update JsonCpp
Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
To state the obvious, JsonCpp is a third party library we're using to parse Json in the library.
We were using quite an outdated version so I updated it to the latest release (1.9.1).
This also means we had to change the way we're using the library (the classes we used to use are now deprecated) so I added a helper class so we don't have to put in a lot of boilerplate code.
🕶️ Types of changes
🤯 List of changes
Closes #4463
🔎 Review hints