fix(electron): add missing configureAppThemeModule to shell #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
mod:i18n
pengx17
force-pushed
the
11-01-fix_electron_add_missing_configureappthememodule_to_shell
branch
from
f6eaf09 to
40fc7b7
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4f16e22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8656 +/- ##
==========================================
+ Coverage 70.05% 70.72% +0.66%
==========================================
Files 545 545
Lines 33774 33774
Branches 3035 3073 +38
==========================================
+ Hits 23662 23886 +224
+ Misses 9755 9549 -206
+ Partials 357 339 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Nov 1, 2024
pengx17
changed the base branch from
11-01-revert_electron_revert_http_protocl_in_electron
to
graphite-base/8656
forehalo
approved these changes
Nov 1, 2024
Merge activity
|
pengx17
force-pushed
the
11-01-fix_electron_add_missing_configureappthememodule_to_shell
branch
from
40fc7b7 to
4f16e22
Compare
graphite-app
bot
deleted the
11-01-fix_electron_add_missing_configureappthememodule_to_shell
branch
Merged
donteatfriedrice
added a commit
that referenced
this pull request
Nov 5, 2024
## Feat - feat: add pdf viewer to playground (#8650) - feat: add view toggle menu to toolbar of attachment block (#8660) - feat: attachment embedded view supports configurable (#8658) ## Fix - fix: tidy up after multiple images uploaded (#8671) - fix: unable to add caption for linked document of embedded view (#8670) - fix(blocks): code block should update highlight when theme changed (#8669) - fix(edgeless): allow right click of tool controller (#8652) - fix(database): short name of tag type (#8665) - fix: the content of formula should contain spaces (#8647) - fix: import notion database with title (#8661) - fix(page): bookmark block selected style (#8656) - fix(edgeless): switching shape style and color, the preview does not change in time (#8655) - fix(blocks): size of icons are not consistent in keyboard toolbar (#8653) - fix: use host instead of offsetParent (#8651) ## Refactor - refactor(database): filter ui (#8611) ## Ci - ci: renovate pr title lint (#8666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.