Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): tracking events for doc properties #8651

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Oct 31, 2024

fix AF-1565

Copy link

graphite-app bot commented Oct 31, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Oct 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Oct 31, 2024
@pengx17 pengx17 marked this pull request as ready for review October 31, 2024 15:56
Copy link

nx-cloud bot commented Oct 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ef82b9d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (4977055) to head (ef82b9d).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...mon/infra/src/modules/doc/stores/doc-properties.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8651      +/-   ##
==========================================
+ Coverage   70.06%   70.08%   +0.01%     
==========================================
  Files         546      546              
  Lines       33809    33809              
  Branches     3055     3055              
==========================================
+ Hits        23689    23694       +5     
+ Misses       9759     9753       -6     
- Partials      361      362       +1     
Flag Coverage Δ
server-test 77.12% <ø> (ø)
unittest 44.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 10-31-chore_core_tracking_events_for_doc_properties branch from 6336312 to ff87fe0 Compare November 1, 2024 01:53
Copy link
Collaborator Author

pengx17 commented Nov 1, 2024

Merge activity

  • Nov 1, 3:07 AM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 5, 5:43 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Nov 5, 6:00 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 5, 6:45 AM EST: A user merged this pull request with the Graphite merge queue.

@pengx17 pengx17 force-pushed the 10-31-chore_core_tracking_events_for_doc_properties branch from ff87fe0 to d4fdb3e Compare November 1, 2024 07:45
@pengx17 pengx17 force-pushed the 10-31-chore_core_tracking_events_for_doc_properties branch from d4fdb3e to 824e2a2 Compare November 4, 2024 07:36
@pengx17 pengx17 force-pushed the 10-31-chore_core_tracking_events_for_doc_properties branch from 824e2a2 to 4cc48e3 Compare November 4, 2024 10:58
@pengx17 pengx17 requested a review from forehalo November 5, 2024 01:56
@pengx17 pengx17 force-pushed the 10-31-chore_core_tracking_events_for_doc_properties branch from 4cc48e3 to 49dfaaf Compare November 5, 2024 03:09
donteatfriedrice added a commit that referenced this pull request Nov 5, 2024
## Feat

- feat: add pdf viewer to playground (#8650)
- feat: add view toggle menu to toolbar of attachment block (#8660)
- feat: attachment embedded view supports configurable (#8658)

## Fix

- fix: tidy up after multiple images uploaded (#8671)
- fix: unable to add caption for linked document of embedded view (#8670)
- fix(blocks): code block should update highlight when theme changed (#8669)
- fix(edgeless): allow right click of tool controller (#8652)
- fix(database): short name of tag type (#8665)
- fix: the content of formula should contain spaces (#8647)
- fix: import notion database with title (#8661)
- fix(page): bookmark block selected style (#8656)
- fix(edgeless): switching shape style and color, the preview does not change in time (#8655)
- fix(blocks): size of icons are not consistent in keyboard toolbar (#8653)
- fix: use host instead of offsetParent (#8651)

## Refactor

- refactor(database): filter ui (#8611)

## Ci

- ci: renovate pr title lint (#8666)
@pengx17 pengx17 force-pushed the 10-31-chore_core_tracking_events_for_doc_properties branch from 49dfaaf to 2ecc414 Compare November 5, 2024 10:43
@pengx17 pengx17 force-pushed the 10-31-chore_core_tracking_events_for_doc_properties branch from 2ecc414 to ef82b9d Compare November 5, 2024 11:31
@graphite-app graphite-app bot merged commit ef82b9d into canary Nov 5, 2024
45 checks passed
@graphite-app graphite-app bot deleted the 10-31-chore_core_tracking_events_for_doc_properties branch November 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants