Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): auth #7994

Merged
merged 1 commit into from
Sep 3, 2024
Merged

refactor(server): auth #7994

merged 1 commit into from
Sep 3, 2024

Conversation

forehalo
Copy link
Member

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Aug 27, 2024
Copy link
Member Author

forehalo commented Aug 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 27, 2024

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 59 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (821de0a) to head (8b0afd6).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ackages/backend/server/src/core/auth/controller.ts 68.00% 32 Missing ⚠️
packages/backend/server/src/core/auth/service.ts 91.95% 14 Missing ⚠️
...ges/backend/server/src/plugins/oauth/controller.ts 93.22% 4 Missing ⚠️
packages/backend/server/src/core/user/service.ts 57.14% 3 Missing ⚠️
packages/backend/server/src/core/auth/guard.ts 90.00% 2 Missing ⚠️
...ages/backend/server/src/core/common/admin-guard.ts 0.00% 2 Missing ⚠️
...ges/backend/server/src/core/selfhost/controller.ts 0.00% 1 Missing ⚠️
...s/backend/server/src/fundamentals/utils/request.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7994      +/-   ##
==========================================
- Coverage   52.63%   52.51%   -0.13%     
==========================================
  Files        1220     1220              
  Lines       47842    47755      -87     
  Branches     5891     5857      -34     
==========================================
- Hits        25184    25080     -104     
- Misses      22286    22303      +17     
  Partials      372      372              
Flag Coverage Δ
server-test 77.44% <85.71%> (-0.15%) ⬇️
unittest 25.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo marked this pull request as draft August 28, 2024 03:08
@forehalo forehalo mentioned this pull request Aug 28, 2024
@forehalo forehalo marked this pull request as ready for review August 28, 2024 11:24
@forehalo forehalo force-pushed the 61/auth-server branch 2 times, most recently from 30fbc58 to a85fbc0 Compare August 29, 2024 02:24
@forehalo forehalo force-pushed the 61/auth-server branch 5 times, most recently from de4b3b4 to f6599b3 Compare September 3, 2024 04:21
Copy link

graphite-app bot commented Sep 3, 2024

Merge activity

@graphite-app graphite-app bot merged commit 8b0afd6 into canary Sep 3, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 61/auth-server branch September 3, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants