-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate throttler config for new throttler version #6002
Conversation
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @darkskygit and the rest of your teammates on Graphite |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1a96495. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## darksky/captcha-modular #6002 +/- ##
========================================================
Coverage 39.03% 39.03%
========================================================
Files 356 356
Lines 7262 7262
Branches 1262 1262
========================================================
Hits 2835 2835
Misses 4209 4209
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -58,7 +58,7 @@ export class NextAuthController { | |||
@Throttle({ | |||
default: { | |||
limit: 60, | |||
ttl: 60, | |||
ttl: 60 * 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am always thinking the current using of throttler for every api is so verbose.
We could have some predefined options and easily to be referenced by name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apis has changed a lot since last time i config the throttler, since you have mention it, i plan to reorganize the api throttle configuration except auth in this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously due to frequent of session request and swr's re-validation, i have significantly relax the throttlor limit, its time to adjust
256a053
to
858bf26
Compare
870c671
to
cddf181
Compare
858bf26
to
df14857
Compare
8344fdf
to
f3ac634
Compare
f0c3aed
to
5c5208b
Compare
96b157e
to
3f16f57
Compare
d8287d7
to
b050be7
Compare
3f16f57
to
18affb0
Compare
9e4f04b
to
db478c1
Compare
18affb0
to
0ab69bc
Compare
db478c1
to
5b5fd24
Compare
0ab69bc
to
6d7dc24
Compare
5b5fd24
to
b513860
Compare
6d7dc24
to
b848dca
Compare
b513860
to
122a1a7
Compare
c2b7fc1
to
db49ad9
Compare
05d9b67
to
1a96495
Compare
015a230
to
637008b
Compare
32cf99a
to
3efcd11
Compare
outdated, close |
No description provided.