Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1866] updates description text for buying stock tokens #10054

Merged
merged 2 commits into from
Dec 30, 2023
Merged

[1866] updates description text for buying stock tokens #10054

merged 2 commits into from
Dec 30, 2023

Conversation

philcampeau
Copy link
Collaborator

@philcampeau philcampeau commented Dec 29, 2023 •
edited
Loading

Fixes #10050

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change
    Updates the description text when buying Stock tokens to be a little more precise.

  • Screenshots

  • Any Assumptions / Hacks

@michaeljb michaeljb merged commit d8f7a28 into tobymao:master Dec 30, 2023
1 check passed
@philcampeau philcampeau deleted the 1866-description-update branch January 6, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnusstjarnhild magnusstjarnhild Awaiting requested review from magnusstjarnhild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1866] misleading text when buying stock token in OR
2 participants
@philcampeau @michaeljb