Huge cleaning and refactoring #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regression. - Get rid of the "env" param and use @request everywhere - Extracted constraint matching in a new dedicated class - Simplified logic by x10000! ;) Next step is to add specific tests for SslEnforcerConstraint...
|
Also, what do you think about replacing |
|
nice, +1! |
|
Rymai, thanks for your effort in cleaning this up, i'd be glad to see this merged in. Also +1 for the renaming... |
|
I've refactored the tests and improved/completed the README (and converted it to Markdown). |
|
@tobmatth Could you activate the Travis CI hook? |
[x] done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests unchanged so there should be no regression.
Here is the summary of my changes:
@requesteverywhereSslEnforcerConstraintclassNext step is to add specific tests for
SslEnforcerConstraint...Let me know guys what you think (so I can merge it myself, or not)! :)