Rewrite of enforce_ssl? and implementation of new options only_methods and except_methods. #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For "methods" a 3rd type of options I've rewritten the enforce_ssl? method to generate all condition variants of options from a keys_by_type hash (maybe the variable should be named options_by_type or matcher_options_by_type).
Now we should only need 1 test context with one pair of matcher option types and could remove all the other contexts testing all possible variants.
So I also have not written new test contexts for testing variants like only_method & only_host & only.