Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of enforce_ssl? and implementation of new options only_methods and except_methods. #32

Merged
merged 2 commits into from
Mar 6, 2012
Merged

Conversation

volontarian
Copy link

For "methods" a 3rd type of options I've rewritten the enforce_ssl? method to generate all condition variants of options from a keys_by_type hash (maybe the variable should be named options_by_type or matcher_options_by_type).

Now we should only need 1 test context with one pair of matcher option types and could remove all the other contexts testing all possible variants.

So I also have not written new test contexts for testing variants like only_method & only_host & only.

@rymai
Copy link
Collaborator

rymai commented Mar 5, 2012

Thanks man,

I'll try to review this tomorrow but looks good from what I've seen!

@rymai rymai merged commit 57687ab into tobmatth:master Mar 6, 2012
@rymai
Copy link
Collaborator

rymai commented Mar 6, 2012

Thanks, I've merged it.

It also give me motivation for refactoring the whole gem (see #33)! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants