Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment dist_func parameter to enable PBCs with predictive tracking #376

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Uncomment dist_func parameter to enable PBCs with predictive tracking #376

merged 2 commits into from
Dec 6, 2023

Conversation

w-k-jones
Copy link
Member

@w-k-jones w-k-jones commented Dec 1, 2023 •
edited
Loading

The most minor of changes to resolve #375

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones self-assigned this Dec 1, 2023
@w-k-jones w-k-jones added bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review labels Dec 1, 2023
@w-k-jones w-k-jones added this to the Version 1.5.2 milestone Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (509a17c) 56.91% compared to head (a3813e9) 56.91%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           RC_v1.5.x     #376   +/-   ##
==========================================
  Coverage      56.91%   56.91%           
==========================================
  Files             20       20           
  Lines           3440     3440           
==========================================
  Hits            1958     1958           
  Misses          1482     1482
Flag Coverage Δ
unittests 56.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@w-k-jones w-k-jones changed the base branch from main to RC_v1.5.x December 1, 2023 17:52
freemansw1
freemansw1 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@freemansw1 freemansw1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add tests around this longer-term, but I'm happy to approve now.

@w-k-jones
Copy link
Member Author

We should probably add tests around this longer-term, but I'm happy to approve now.

I've now added a basic set of tests to check that predictive tracking across PBCs works as expected

@w-k-jones w-k-jones requested a review from fsenf December 3, 2023 23:14
@freemansw1 freemansw1 mentioned this pull request Dec 4, 2023
Merged
11 tasks
freemansw1
freemansw1 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test, @w-k-jones

JuliaKukulies
JuliaKukulies approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks for fixing this @w-k-jones !

@w-k-jones w-k-jones merged commit afe7c33 into tobac-project:RC_v1.5.x Dec 6, 2023
20 checks passed
@w-k-jones w-k-jones mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKukulies JuliaKukulies JuliaKukulies approved these changes

@freemansw1 freemansw1 freemansw1 approved these changes

@fziegner fziegner Awaiting requested review from fziegner

@fsenf fsenf Awaiting requested review from fsenf

Assignees

@w-k-jones w-k-jones

Labels
bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review
Projects
None yet
Milestone
Version 1.5.2
Development

Successfully merging this pull request may close these issues.

PBC dist_func not used for predictive tracking
3 participants
@w-k-jones @freemansw1 @JuliaKukulies