Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBC dist_func not used for predictive tracking #375

Closed
w-k-jones opened this issue Nov 30, 2023 · 3 comments · Fixed by #376
Closed

PBC dist_func not used for predictive tracking #375

w-k-jones opened this issue Nov 30, 2023 · 3 comments · Fixed by #376
Assignees
@w-k-jones
Labels
bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review
Milestone
Version 1.5.2

Comments

@w-k-jones
Copy link
Member

w-k-jones commented Nov 30, 2023 •
edited
Loading

For predictive tracking, the dist_func keyword (used for the PBC distance calculation) is commented out. Can this be safely re-enabled? It seems to be working fine for me locally, and correctly tracks cells across periodic boundaries when uncommented

tobac/tobac/tracking.py

Line 391 in f1d3a4e

# dist_func=dist_func

@w-k-jones w-k-jones added bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review labels Nov 30, 2023
@w-k-jones
Copy link
Member Author

@freemansw1 This was commented out as part of #209, I guess was this part of separating the 3D and PBC additions and it never got re-added with the PBCs?

@freemansw1
Copy link
Member

@freemansw1 This was commented out as part of #209, I guess was this part of separating the 3D and PBC additions and it never got re-added with the PBCs?

This seems likely. We can do a PR to uncomment.

@w-k-jones w-k-jones mentioned this issue Dec 1, 2023
Merged
11 tasks
@w-k-jones w-k-jones added this to the Version 1.5.2 milestone Dec 2, 2023
@w-k-jones w-k-jones self-assigned this Dec 4, 2023
@w-k-jones
Copy link
Member Author

Resolved by #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w-k-jones w-k-jones

Labels
bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review
Projects
None yet
Milestone
Version 1.5.2
Development

Successfully merging a pull request may close this issue.

Uncomment dist_func parameter to enable PBCs with predictive tracking w-k-jones/tobac
2 participants
@freemansw1 @w-k-jones