Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Jupyter Notebook CI #340

Merged

Conversation

freemansw1
Copy link
Member

@freemansw1 freemansw1 commented Sep 12, 2023

Resolves #339 and fixes our Jupyter Notebook CI by switching the dependency installer to mamba from conda. Also fixed a bug with our requirements that did not explicitly require h5netcdf which is required for the example that uses s3 to work.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Sep 12, 2023
@freemansw1 freemansw1 added this to the Version 1.5.1 milestone Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0a695fc) 55.74% compared to head (63f9205) 55.74%.

Additional details and impacted files
@@               Coverage Diff               @@
##           RC_v1.5_hotfix     #340   +/-   ##
===============================================
  Coverage           55.74%   55.74%           
===============================================
  Files                  15       15           
  Lines                3310     3310           
===============================================
  Hits                 1845     1845           
  Misses               1465     1465           
Flag Coverage Δ
unittests 55.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. At some point we should also look into caching CI environments

@freemansw1
Copy link
Member Author

freemansw1 commented Sep 12, 2023

Looks good. At some point we should also look into caching CI environments

Agreed. This is just a hotfix for now. I will say though that the installing environments step isn't the largest time suck (about 3 minutes with mamba now on the example notebooks).

@fsenf fsenf self-requested a review September 13, 2023 06:50
Copy link
Member

@fsenf fsenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also confirm that everything looks fine! However, we need to keep an eye on notebook CI in future

  1. It will become bigger soon
  2. mamba is still experimental (see warming in CI summary)

@fsenf
Copy link
Member

fsenf commented Sep 13, 2023

@freemansw1 : You can go ahead and merge now!

@freemansw1 freemansw1 merged commit 6b573c0 into tobac-project:RC_v1.5_hotfix Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants