-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Jupyter Notebook CI #340
Fix for Jupyter Notebook CI #340
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5_hotfix #340 +/- ##
===============================================
Coverage 55.74% 55.74%
===============================================
Files 15 15
Lines 3310 3310
===============================================
Hits 1845 1845
Misses 1465 1465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. At some point we should also look into caching CI environments
Co-authored-by: William Jones <[email protected]>
Agreed. This is just a hotfix for now. I will say though that the installing environments step isn't the largest time suck (about 3 minutes with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also confirm that everything looks fine! However, we need to keep an eye on notebook CI in future
- It will become bigger soon
- mamba is still experimental (see warming in CI summary)
@freemansw1 : You can go ahead and merge now! |
Resolves #339 and fixes our Jupyter Notebook CI by switching the dependency installer to
mamba
fromconda
. Also fixed a bug with our requirements that did not explicitly requireh5netcdf
which is required for the example that uses s3 to work.