Skip to content

Commit

Permalink
Merge pull request #340 from freemansw1/jupyter_notebook_fix
Browse files Browse the repository at this point in the history
Fix for Jupyter Notebook CI
  • Loading branch information
freemansw1 authored Sep 13, 2023
2 parents 0a695fc + 63f9205 commit 6b573c0
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/check_notebooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,19 @@ jobs:
- name: set up conda environment
uses: conda-incubator/setup-miniconda@v2
with:
miniforge-version: latest
miniforge-variant: mambaforge
channel-priority: strict
channels: conda-forge
show-channel-urls: true
use-only-tar-bz2: true
auto-update-conda: true
auto-activate-base: false
activate-environment: notebook-env
- name: Install tobac dependencies
run: |
conda install -c conda-forge --yes ffmpeg gcc jupyter pytables
conda install -c conda-forge --yes --file example_requirements.txt
mamba install -c conda-forge --yes ffmpeg gcc jupyter pytables
mamba install -c conda-forge --yes --file example_requirements.txt
- name: Install tobac
run: |
pip install .
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ _**Version 1.5.1:**_
- Fix to readthedocs building after system packages no longer imported [#336](https://github.com/tobac-project/tobac/pull/336)
- The `strict_thresholding` option in feature detection now works correctly for detecting minima, and produces the same results as without strict thresholding if the `n_min_threshold` is a scalar value [#316](https://github.com/tobac-project/tobac/pull/316)

**Repository Enhancements**
- Fix to Jupyter Notebook CI that was timing out due to installing packages with `conda`, switched to `mamba` to resolve. [#340](https://github.com/tobac-project/tobac/pull/340)


_**Version 1.5.0:**_

Expand Down
1 change: 1 addition & 0 deletions example_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ notebook
pytables
s3fs
arm_pyart
h5netcdf

0 comments on commit 6b573c0

Please sign in to comment.