Fix TermsSetQueryBuilder.doEquals() method

Closes elastic#29620
tlrx · Apr 26, 2018 · 9f82709 · 9f82709
1 parent fadcce8
commit 9f82709
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/server/src/main/java/org/elasticsearch/index/query/TermsSetQueryBuilder.java b/server/src/main/java/org/elasticsearch/index/query/TermsSetQueryBuilder.java
@@ -116,9 +116,10 @@ public TermsSetQueryBuilder setMinimumShouldMatchScript(Script minimumShouldMatc
 
     @Override
     protected boolean doEquals(TermsSetQueryBuilder other) {
-        return Objects.equals(fieldName, this.fieldName) && Objects.equals(values, this.values) &&
-                Objects.equals(minimumShouldMatchField, this.minimumShouldMatchField) &&
-                Objects.equals(minimumShouldMatchScript, this.minimumShouldMatchScript);
+        return Objects.equals(fieldName, other.fieldName)
+            && Objects.equals(values, other.values)
+            && Objects.equals(minimumShouldMatchField, other.minimumShouldMatchField)
+            && Objects.equals(minimumShouldMatchScript, other.minimumShouldMatchScript);
     }
 
     @Override