Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TermsSetQueryBuilder#doEquals is incorrect #29620

Closed
twilson-palantir opened this issue Apr 19, 2018 · 2 comments
Closed

TermsSetQueryBuilder#doEquals is incorrect #29620

twilson-palantir opened this issue Apr 19, 2018 · 2 comments
Labels
>bug :Search/Search Search-related issues that do not fall into other categories

Comments

@twilson-palantir
Copy link

Currently written as

    protected boolean doEquals(TermsSetQueryBuilder other) {
        return Objects.equals(fieldName, this.fieldName) && Objects.equals(values, this.values) &&
                Objects.equals(minimumShouldMatchField, this.minimumShouldMatchField) &&
                Objects.equals(minimumShouldMatchScript, this.minimumShouldMatchScript);
    }

should be

    protected boolean doEquals(TermsSetQueryBuilder other) {
        return Objects.equals(fieldName, other.fieldName) && Objects.equals(values, other.values) &&
                Objects.equals(minimumShouldMatchField, other.minimumShouldMatchField) &&
                Objects.equals(minimumShouldMatchScript, other.minimumShouldMatchScript);
    }
@tlrx
Copy link
Member

tlrx commented Apr 20, 2018

Thanks @twilson-palantir, I created #29629

@tlrx tlrx added >bug :Search/Search Search-related issues that do not fall into other categories labels Apr 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

tlrx added a commit to tlrx/elasticsearch that referenced this issue Apr 26, 2018
tlrx added a commit that referenced this issue Apr 26, 2018
tlrx added a commit that referenced this issue Apr 26, 2018
tlrx added a commit that referenced this issue Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Development

No branches or pull requests

3 participants