Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-verify-tag: add page #6139

Merged
merged 4 commits into from
Jun 29, 2021
Merged

git-verify-tag: add page #6139

merged 4 commits into from
Jun 29, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #3953

@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jun 17, 2021
@CleanMachine1
Copy link
Member Author

Make sure to take a look at #5946

@tldr-pages tldr-pages deleted a comment from tldr-bot Jun 17, 2021
@tldr-pages tldr-pages deleted a comment from tldr-bot Jun 17, 2021
@CleanMachine1
Copy link
Member Author

Also the Gitter section, I have left some more comments

pages/common/git-verify-tag.md Outdated Show resolved Hide resolved
pages/common/git-verify-tag.md Outdated Show resolved Hide resolved
git-verify-tag: please the bot

git-verify-tag: please the bot
@CleanMachine1
Copy link
Member Author

Thought it was ironic that the verify-tag page wasn't signed, since my key was removed. So I rebased and squashed and signed it

@tldr-pages tldr-pages locked as too heated and limited conversation to collaborators Jun 21, 2021
@tldr-pages tldr-pages unlocked this conversation Jun 21, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Jun 21, 2021

(Sorry, I just wanted to test the locking feature 😄 — turns out even collaborators can't react/unreact 🤔)
(also, that says "bl-ue locked" to us, but to a non-collaborator it would say "tldr-pages locked")

@CleanMachine1
Copy link
Member Author

That should probably be changed to give the option

@sbrl
Copy link
Member

sbrl commented Jun 23, 2021

The idea there @CleanMachine1 is that by saying tldr-pages locked, it avoids publicly naming the person who locked the thread. This is important in heated situations because otherewise the person doing the locking may be targeted on other platforms and the conversation might just continue anyway. That way they allow everyone some cooling off time.

Thankfully we've never had a need to use that feature haha

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me after @marchersimon's comment is addressed.

@bl-ue
Copy link
Contributor

bl-ue commented Jun 23, 2021

the person doing the locking may be targeted on other platforms

Often though, the one doing the locking says "I'm going to lock this now" or something similar before doing it 😉

Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@CleanMachine1
Copy link
Member Author

  • Bl-ue's approval makes it 3

@CleanMachine1 CleanMachine1 merged commit cc75565 into main Jun 29, 2021
@CleanMachine1 CleanMachine1 deleted the git-verify-tag branch June 29, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants