-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-verify-tag: add page #6139
git-verify-tag: add page #6139
Conversation
Make sure to take a look at #5946 |
Also the Gitter section, I have left some more comments |
git-verify-tag: please the bot git-verify-tag: please the bot
7de0b82
to
fda5e64
Compare
Thought it was ironic that the verify-tag page wasn't signed, since my key was removed. So I rebased and squashed and signed it |
Co-authored-by: marchersimon <[email protected]>
(Sorry, I just wanted to test the locking feature 😄 — turns out even collaborators can't react/unreact 🤔) |
That should probably be changed to give the option |
The idea there @CleanMachine1 is that by saying Thankfully we've never had a need to use that feature haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me after @marchersimon's comment is addressed.
Often though, the one doing the locking says "I'm going to lock this now" or something similar before doing it 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
|
common/
,linux/
, etc.)For #3953