-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-verify-commit: add page #5946
git-verify-commit: add page #5946
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer snake_and_lower_case ;)
disagree with the changes with your first review, your changes make it look messier in my opinion |
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: marchersimon <[email protected]>
Co-authored-by: marchersimon <[email protected]>
Co-authored-by: marchersimon <[email protected]>
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not a fan of the optional
, but looks good otherwise.
24 Hours passed and already had 3 reviewers |
Rebased, instead of squashed, that was a mistake. |
Yeah, be careful about that...https://github.com/tldr-pages/tldr/commits/main looks a bit messy now 😂 But don't worry — it'll soon be washed down into history and be forgotten 💨 |
common/
,linux/
, etc.)For #3953