-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ip-neighbour: add page #5697
ip-neighbour: add page #5697
Conversation
be2c40a
to
90237f7
Compare
@patricedenis will you please use the manned.org link here? |
@patricedenis: after we've applied all of the suggestions, let's rename this this page, the PR, and the commands from |
All right, that what I just ask before so I will do it as well. |
I think I will commit all the suggestions and after that I will rebase the whole to have a clean "add page PR". It is better as I understood, am I right? |
1d4d057
to
b370172
Compare
Really, it doesn't matter at all. Since we squash all of the commits into one just before merging, it will end up as one clean commit whether you yourself make a clean commit or messy commits. I recommend taking it easy and just committing as necessary, not bothering to rebase, because you can. |
I tried to rename the branch and it closed the PR, is that normal?
All right. |
I see, I'm not sure if you can do that; at any rate, this is a temporary branch and so the name matters little. You could even call it |
Now wait, it looks like maybe Maybe you should actually revert and go back to the British spelling... 🙂 |
@bl-ue I forgot to check that too, sorry. I just looked if |
I think @bl-ue is right because I couldn't find any Should we add a note to enlighten that |
I don't really think so; they're so similar that pointing that might just be distracting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @patricedenis!
common/
,linux/
, etc.)