Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle allowUnknownOption in .parseOptions() #1946

Closed
wants to merge 5 commits into from
Closed

Correctly handle allowUnknownOption in .parseOptions() #1946

wants to merge 5 commits into from

Commits on Aug 7, 2023

  1. Correctly handle allowUnknownOption in parseOptions() 

    Partially borrowed from tj#1934
    @aweebit
    aweebit committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    5e35531 View commit details
    Browse the repository at this point in the history

  2. Add test for unknown option parsing when using allowUnknownOption

    @aweebit
    aweebit committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ab9b930 View commit details
    Browse the repository at this point in the history

  3. Remove incorrect unknown option test

    @aweebit
    aweebit committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    83ca473 View commit details
    Browse the repository at this point in the history

  4. Remove comment detail only relevant in tj#1934

    @aweebit
    aweebit committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3a0f307 View commit details
    Browse the repository at this point in the history

  5. Refactor parseOptions() 

    Export check to variable for clarity and potential future uses
    @aweebit
    aweebit committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ef6acf4 View commit details
    Browse the repository at this point in the history