Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle allowUnknownOption in .parseOptions() #1946

Conversation

aweebit
Copy link
Contributor

@aweebit aweebit commented Aug 7, 2023

Problem

#1945

Solution

Implement the first solution suggested in the issue.

Unknown options are now treated as command-arguments in .parseOptions() as suggested by the docs.

The incorrect test has been removed.

ChangeLog

Fixed

  • Breaking: treat unknown options as command-arguments in .parseOptions() as suggested by the docs

Export check to variable for clarity and potential future uses
@shadowspawn
Copy link
Collaborator

The current behaviour is as intended. .parseOptions() is an internal routine not affected by .allowUnknownOption().

See longer explanation of .parseOptions() in issue: #1945 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants